[lld] r228453 - Use make_unique.

Rui Ueyama ruiu at google.com
Fri Feb 6 14:44:17 PST 2015


Author: ruiu
Date: Fri Feb  6 16:44:16 2015
New Revision: 228453

URL: http://llvm.org/viewvc/llvm-project?rev=228453&view=rev
Log:
Use make_unique.

Modified:
    lld/trunk/lib/Driver/Driver.cpp
    lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64RelocationPass.cpp
    lld/trunk/lib/ReaderWriter/ELF/ARM/ARMRelocationPass.cpp
    lld/trunk/lib/ReaderWriter/ELF/ELFLinkingContext.cpp
    lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonTargetHandler.cpp
    lld/trunk/lib/ReaderWriter/ELF/Mips/MipsLinkingContext.cpp
    lld/trunk/lib/ReaderWriter/ELF/Mips/MipsRelocationPass.cpp
    lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64RelocationPass.cpp
    lld/trunk/lib/ReaderWriter/MachO/CompactUnwindPass.cpp
    lld/trunk/lib/ReaderWriter/MachO/GOTPass.cpp
    lld/trunk/lib/ReaderWriter/MachO/LayoutPass.cpp
    lld/trunk/lib/ReaderWriter/MachO/ShimPass.cpp
    lld/trunk/lib/ReaderWriter/PECOFF/PECOFFLinkingContext.cpp

Modified: lld/trunk/lib/Driver/Driver.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Driver/Driver.cpp?rev=228453&r1=228452&r2=228453&view=diff
==============================================================================
--- lld/trunk/lib/Driver/Driver.cpp (original)
+++ lld/trunk/lib/Driver/Driver.cpp Fri Feb  6 16:44:16 2015
@@ -122,8 +122,8 @@ bool Driver::link(LinkingContext &contex
       llvm::sys::Process::GetEnv("LLD_RUN_ROUNDTRIP_TEST");
 
   if (env.hasValue() && !env.getValue().empty()) {
-    pm.add(std::unique_ptr<Pass>(new RoundTripYAMLPass(context)));
-    pm.add(std::unique_ptr<Pass>(new RoundTripNativePass(context)));
+    pm.add(llvm::make_unique<RoundTripYAMLPass>(context));
+    pm.add(llvm::make_unique<RoundTripNativePass>(context));
   }
 #endif
 

Modified: lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64RelocationPass.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64RelocationPass.cpp?rev=228453&r1=228452&r2=228453&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64RelocationPass.cpp (original)
+++ lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64RelocationPass.cpp Fri Feb  6 16:44:16 2015
@@ -518,13 +518,12 @@ lld::elf::createAArch64RelocationPass(co
   switch (ctx.getOutputELFType()) {
   case llvm::ELF::ET_EXEC:
     if (ctx.isDynamic())
-      return std::unique_ptr<Pass>(new AArch64DynamicRelocationPass(ctx));
-    else
-      return std::unique_ptr<Pass>(new AArch64StaticRelocationPass(ctx));
+      return llvm::make_unique<AArch64DynamicRelocationPass>(ctx);
+    return llvm::make_unique<AArch64StaticRelocationPass>(ctx);
   case llvm::ELF::ET_DYN:
-    return std::unique_ptr<Pass>(new AArch64DynamicRelocationPass(ctx));
+    return llvm::make_unique<AArch64DynamicRelocationPass>(ctx);
   case llvm::ELF::ET_REL:
-    return std::unique_ptr<Pass>();
+    return nullptr;
   default:
     llvm_unreachable("Unhandled output file type");
   }

Modified: lld/trunk/lib/ReaderWriter/ELF/ARM/ARMRelocationPass.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/ARM/ARMRelocationPass.cpp?rev=228453&r1=228452&r2=228453&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/ARM/ARMRelocationPass.cpp (original)
+++ lld/trunk/lib/ReaderWriter/ELF/ARM/ARMRelocationPass.cpp Fri Feb  6 16:44:16 2015
@@ -128,8 +128,7 @@ lld::elf::createARMRelocationPass(const
   case llvm::ELF::ET_EXEC:
     if (ctx.isDynamic())
       llvm_unreachable("Unhandled output file type");
-    else
-      return std::unique_ptr<Pass>(new ARMStaticRelocationPass(ctx));
+    return llvm::make_unique<ARMStaticRelocationPass>(ctx);
   default:
     llvm_unreachable("Unhandled output file type");
   }

Modified: lld/trunk/lib/ReaderWriter/ELF/ELFLinkingContext.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/ELFLinkingContext.cpp?rev=228453&r1=228452&r2=228453&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/ELFLinkingContext.cpp (original)
+++ lld/trunk/lib/ReaderWriter/ELF/ELFLinkingContext.cpp Fri Feb  6 16:44:16 2015
@@ -65,7 +65,7 @@ ELFLinkingContext::ELFLinkingContext(
       _finiFunction("_fini"), _sysrootPath("") {}
 
 void ELFLinkingContext::addPasses(PassManager &pm) {
-  pm.add(std::unique_ptr<Pass>(new elf::OrderPass()));
+  pm.add(llvm::make_unique<elf::OrderPass>());
 }
 
 uint16_t ELFLinkingContext::getOutputMachine() const {

Modified: lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonTargetHandler.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonTargetHandler.cpp?rev=228453&r1=228452&r2=228453&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonTargetHandler.cpp (original)
+++ lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonTargetHandler.cpp Fri Feb  6 16:44:16 2015
@@ -319,7 +319,7 @@ public:
 
 void elf::HexagonLinkingContext::addPasses(PassManager &pm) {
   if (isDynamic())
-    pm.add(std::unique_ptr<Pass>(new DynamicGOTPLTPass(*this)));
+    pm.add(llvm::make_unique<DynamicGOTPLTPass>(*this));
   ELFLinkingContext::addPasses(pm);
 }
 

Modified: lld/trunk/lib/ReaderWriter/ELF/Mips/MipsLinkingContext.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Mips/MipsLinkingContext.cpp?rev=228453&r1=228452&r2=228453&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/Mips/MipsLinkingContext.cpp (original)
+++ lld/trunk/lib/ReaderWriter/ELF/Mips/MipsLinkingContext.cpp Fri Feb  6 16:44:16 2015
@@ -71,7 +71,7 @@ void MipsLinkingContext::addPasses(PassM
   if (pass)
     pm.add(std::move(pass));
   ELFLinkingContext::addPasses(pm);
-  pm.add(std::unique_ptr<Pass>(new elf::MipsCtorsOrderPass()));
+  pm.add(llvm::make_unique<elf::MipsCtorsOrderPass>());
 }
 
 bool MipsLinkingContext::isDynamicRelocation(const DefinedAtom &,

Modified: lld/trunk/lib/ReaderWriter/ELF/Mips/MipsRelocationPass.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Mips/MipsRelocationPass.cpp?rev=228453&r1=228452&r2=228453&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/Mips/MipsRelocationPass.cpp (original)
+++ lld/trunk/lib/ReaderWriter/ELF/Mips/MipsRelocationPass.cpp Fri Feb  6 16:44:16 2015
@@ -949,9 +949,9 @@ RelocationPass<ELFT>::getObjectEntry(con
 static std::unique_ptr<Pass> createPass(MipsLinkingContext &ctx) {
   switch (ctx.getTriple().getArch()) {
   case llvm::Triple::mipsel:
-    return std::unique_ptr<Pass>(new RelocationPass<Mips32ELType>(ctx));
+    return llvm::make_unique<RelocationPass<Mips32ELType>>(ctx);
   case llvm::Triple::mips64el:
-    return std::unique_ptr<Pass>(new RelocationPass<Mips64ELType>(ctx));
+    return llvm::make_unique<RelocationPass<Mips64ELType>>(ctx);
   default:
     llvm_unreachable("Unhandled arch");
   }
@@ -964,7 +964,7 @@ lld::elf::createMipsRelocationPass(MipsL
   case llvm::ELF::ET_DYN:
     return createPass(ctx);
   case llvm::ELF::ET_REL:
-    return std::unique_ptr<Pass>();
+    return nullptr;
   default:
     llvm_unreachable("Unhandled output file type");
   }

Modified: lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64RelocationPass.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64RelocationPass.cpp?rev=228453&r1=228452&r2=228453&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64RelocationPass.cpp (original)
+++ lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64RelocationPass.cpp Fri Feb  6 16:44:16 2015
@@ -502,13 +502,12 @@ lld::elf::createX86_64RelocationPass(con
   switch (ctx.getOutputELFType()) {
   case llvm::ELF::ET_EXEC:
     if (ctx.isDynamic())
-      return std::unique_ptr<Pass>(new DynamicRelocationPass(ctx));
-    else
-      return std::unique_ptr<Pass>(new StaticRelocationPass(ctx));
+      return llvm::make_unique<DynamicRelocationPass>(ctx);
+    return llvm::make_unique<StaticRelocationPass>(ctx);
   case llvm::ELF::ET_DYN:
-    return std::unique_ptr<Pass>(new DynamicRelocationPass(ctx));
+    return llvm::make_unique<DynamicRelocationPass>(ctx);
   case llvm::ELF::ET_REL:
-    return std::unique_ptr<Pass>();
+    return nullptr;
   default:
     llvm_unreachable("Unhandled output file type");
   }

Modified: lld/trunk/lib/ReaderWriter/MachO/CompactUnwindPass.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/MachO/CompactUnwindPass.cpp?rev=228453&r1=228452&r2=228453&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/MachO/CompactUnwindPass.cpp (original)
+++ lld/trunk/lib/ReaderWriter/MachO/CompactUnwindPass.cpp Fri Feb  6 16:44:16 2015
@@ -521,7 +521,7 @@ private:
 
 void addCompactUnwindPass(PassManager &pm, const MachOLinkingContext &ctx) {
   assert(ctx.needsCompactUnwindPass());
-  pm.add(std::unique_ptr<Pass>(new CompactUnwindPass(ctx)));
+  pm.add(llvm::make_unique<CompactUnwindPass>(ctx));
 }
 
 } // end namesapce mach_o

Modified: lld/trunk/lib/ReaderWriter/MachO/GOTPass.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/MachO/GOTPass.cpp?rev=228453&r1=228452&r2=228453&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/MachO/GOTPass.cpp (original)
+++ lld/trunk/lib/ReaderWriter/MachO/GOTPass.cpp Fri Feb  6 16:44:16 2015
@@ -177,7 +177,7 @@ private:
 
 void addGOTPass(PassManager &pm, const MachOLinkingContext &ctx) {
   assert(ctx.needsGOTPass());
-  pm.add(std::unique_ptr<Pass>(new GOTPass(ctx)));
+  pm.add(llvm::make_unique<GOTPass>(ctx));
 }
   
 

Modified: lld/trunk/lib/ReaderWriter/MachO/LayoutPass.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/MachO/LayoutPass.cpp?rev=228453&r1=228452&r2=228453&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/MachO/LayoutPass.cpp (original)
+++ lld/trunk/lib/ReaderWriter/MachO/LayoutPass.cpp Fri Feb  6 16:44:16 2015
@@ -484,11 +484,11 @@ void LayoutPass::perform(std::unique_ptr
 }
 
 void addLayoutPass(PassManager &pm, const MachOLinkingContext &ctx) {
-  pm.add(std::unique_ptr<Pass>(new LayoutPass(
+  pm.add(llvm::make_unique<LayoutPass>(
       ctx.registry(), [&](const DefinedAtom * left, const DefinedAtom * right,
                           bool & leftBeforeRight) ->bool {
     return ctx.customAtomOrderer(left, right, leftBeforeRight);
-  })));
+  }));
 }
 
 } // namespace mach_o

Modified: lld/trunk/lib/ReaderWriter/MachO/ShimPass.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/MachO/ShimPass.cpp?rev=228453&r1=228452&r2=228453&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/MachO/ShimPass.cpp (original)
+++ lld/trunk/lib/ReaderWriter/MachO/ShimPass.cpp Fri Feb  6 16:44:16 2015
@@ -122,7 +122,7 @@ private:
 
 
 void addShimPass(PassManager &pm, const MachOLinkingContext &ctx) {
-  pm.add(std::unique_ptr<Pass>(new ShimPass(ctx)));
+  pm.add(llvm::make_unique<ShimPass>(ctx));
 }
 
 } // end namespace mach_o

Modified: lld/trunk/lib/ReaderWriter/PECOFF/PECOFFLinkingContext.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/PECOFF/PECOFFLinkingContext.cpp?rev=228453&r1=228452&r2=228453&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/PECOFF/PECOFFLinkingContext.cpp (original)
+++ lld/trunk/lib/ReaderWriter/PECOFF/PECOFFLinkingContext.cpp Fri Feb  6 16:44:16 2015
@@ -345,12 +345,12 @@ std::string PECOFFLinkingContext::getPDB
 }
 
 void PECOFFLinkingContext::addPasses(PassManager &pm) {
-  pm.add(std::unique_ptr<Pass>(new pecoff::PDBPass(*this)));
-  pm.add(std::unique_ptr<Pass>(new pecoff::EdataPass(*this)));
-  pm.add(std::unique_ptr<Pass>(new pecoff::IdataPass(*this)));
-  pm.add(std::unique_ptr<Pass>(new pecoff::OrderPass()));
-  pm.add(std::unique_ptr<Pass>(new pecoff::LoadConfigPass(*this)));
-  pm.add(std::unique_ptr<Pass>(new pecoff::InferSubsystemPass(*this)));
+  pm.add(llvm::make_unique<pecoff::PDBPass>(*this));
+  pm.add(llvm::make_unique<pecoff::EdataPass>(*this));
+  pm.add(llvm::make_unique<pecoff::IdataPass>(*this));
+  pm.add(llvm::make_unique<pecoff::OrderPass>());
+  pm.add(llvm::make_unique<pecoff::LoadConfigPass>(*this));
+  pm.add(llvm::make_unique<pecoff::InferSubsystemPass>(*this));
 }
 
 } // end namespace lld





More information about the llvm-commits mailing list