[PATCHES] R600/SI: More tests for VI

Matt Arsenault Matthew.Arsenault at amd.com
Fri Feb 6 11:19:16 PST 2015


On 02/06/2015 10:09 AM, Marek Olšák wrote:
> Okay, I moved SI to the first line for all tests I touched. (I suppose
> you don't want me to resend the patches) --check-prefix can be
> replaced by -check-prefix in a later patch if anyone wants to that.
>
> Anything else?
>
> Marek

LGTM

>
> On Thu, Feb 5, 2015 at 8:27 PM, Matt Arsenault
> <Matthew.Arsenault at amd.com> wrote:
>> On 02/05/2015 08:42 AM, Marek Olšák wrote:
>>> +; RUN: llc -march=amdgcn -mcpu=tonga -verify-machineinstrs < %s |
>>> FileCheck -check-prefix=CI -check-prefix=FUNC %s
>>>    ; RUN: llc -march=amdgcn -mcpu=bonaire -verify-machineinstrs < %s |
>>> FileCheck -check-prefix=CI -check-prefix=FUNC %s
>>>    ; RUN: llc -march=amdgcn -mcpu=SI -verify-machineinstrs < %s | FileCheck
>>> -check-prefix=SI -check-prefix=FUNC %s
>> I would prefer to keep SI consistently as the first run line. SI generally
>> should be the most reliable target, and when looking at a new set of
>> failures when working on something I would rather start looking at them on
>> SI. For the same reason I've gradually been moving the r600 run lines to the
>> bottom.
>>
>> -Matt





More information about the llvm-commits mailing list