[PATCH] Add methods to get archive file name from member file

Shankar Kalpathi Easwaran shankarke at gmail.com
Thu Feb 5 14:13:32 PST 2015


Other than the comment LGTM. Thanks for doing this.


================
Comment at: include/lld/Core/File.h:65
@@ -62,1 +64,3 @@
+    return *new (_allocator) std::string(
+      (_archivePath + "(" + _path + ")").str());
   }
----------------
Could we cache this path. 

================
Comment at: include/lld/Core/File.h:69
@@ +68,3 @@
+  /// Returns the path of the archive file name if this file is instantiated
+  /// from an archive file. Otehrwise returns the empty string.
+  StringRef archivePath() const { return _archivePath; }
----------------
Spell error. Otehrwise -> otherwise.

http://reviews.llvm.org/D7447

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list