[PATCH] [lld] Add ArchiveMemoryBuffer.

Rui Ueyama ruiu at google.com
Thu Feb 5 12:20:54 PST 2015


Why do you think this is hacky? It

- is much shorter,
- is easier to understand,
- provides probably the simplest interface to do what you want to do
(File::archivePath),
- doesn't define new class, and
- doesn't propagate information to the other end inside deep function calls
who doesn't really need that information.

It seems to me that this is far better than defining a subclass of
MemoryBuffer.

On Thu, Feb 5, 2015 at 12:12 PM, Shankar Kalpathi Easwaran <
shankarke at gmail.com> wrote:

> I thought about this too, but I felt this was more a hacky solution.
>
>
> http://reviews.llvm.org/D7428
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150205/e9209801/attachment.html>


More information about the llvm-commits mailing list