[llvm] r228300 - Add a FIXME.

Rafael Espindola rafael.espindola at gmail.com
Thu Feb 5 06:57:47 PST 2015


Author: rafael
Date: Thu Feb  5 08:57:47 2015
New Revision: 228300

URL: http://llvm.org/viewvc/llvm-project?rev=228300&view=rev
Log:
Add a FIXME.

Thanks to Eric for the suggestion.

Modified:
    llvm/trunk/lib/CodeGen/TargetLoweringObjectFileImpl.cpp

Modified: llvm/trunk/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/TargetLoweringObjectFileImpl.cpp?rev=228300&r1=228299&r2=228300&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/TargetLoweringObjectFileImpl.cpp (original)
+++ llvm/trunk/lib/CodeGen/TargetLoweringObjectFileImpl.cpp Thu Feb  5 08:57:47 2015
@@ -181,6 +181,9 @@ getELFSectionFlags(SectionKind K, bool I
   if (K.isThreadLocal())
     Flags |= ELF::SHF_TLS;
 
+  // FIXME: There is nothing in ELF preventing an SHF_MERGE from being
+  // in a comdat. We just avoid it for now because we don't print
+  // those .sections correctly.
   if (!InCOMDAT && (K.isMergeableCString() || K.isMergeableConst()))
     Flags |= ELF::SHF_MERGE;
 





More information about the llvm-commits mailing list