PATCH: Don't warn if bash is missing

[NAKAMURA Takumi]

Could you make sure to satisfy you if "warning" were demoted to "note"?

In past, bash tests could run on msys mingw. If we abandon running
tests with msys, I would agree that you might prune those messages.

2015-02-05 3:56 GMT+09:00 Edwards, Michael
<Michael_Edwards at playstation.sony.com>:
> My apologies gents, I was traveling and my email was not behaving
> properly.  Did we reach a conclusion on this?  I¹m happy to use the patch
> supplied or I could also change the warning just to a note if either of
> you think I might be better to leave in for any reason?  Just let me know.
>  Oh, I¹m re-attaching the patch because I think it may have been lost in
> the shuffle from my first submission.  Thanks for your assistance.
>
> -Mike
>
> On 1/29/15, 10:53 AM, "Edwards, Michael"
> <Michael_Edwards at playstation.sony.com> wrote:
>
>>Hi,
>>Yes, when I run the tests I usually get one of two warnings:
>>
>>lit.py: LitConfig.py:79: warning: Unable to find 'bash'.
>>or:
>>lit.py: LitConfig.py:94: note: Unable to find 'bash.exe'.
>>
>>It depends on the setup of the buildslave.  Both the note: and warning:
>>cause a warning on my bot.  So, I too would like to see this go away.
>>Thanks for the response.
>>
>>-Mike
>>
>>________________________________________
>>From: aaron.ballman at gmail.com [aaron.ballman at gmail.com] on behalf of
>>Aaron Ballman [aaron at aaronballman.com]
>>Sent: Thursday, January 29, 2015 10:45 AM
>>To: Edwards, Michael
>>Cc: llvm-commits at cs.uiuc.edu; NAKAMURA Takumi
>>Subject: Re: PATCH: Don't warn if bash is missing
>>
>>On Thu, Jan 29, 2015 at 1:19 PM, Edwards, Michael
>><Michael_Edwards at playstation.sony.com> wrote:
>>> Hi,
>>>
>>>
>>> It looks like bash will always be available on the supported platforms
>>> except Windows.  In Windows we can run the tests without bash.  I'm
>>>hoping
>>> we can remove this warning as it is causing my Buildbots to remain
>>>yellow
>>> all the time.  I'm not sure if it is needed anywhere else?
>>
>>I would love to see that warning go away, and this patch LGTM, but you
>>should wait for someone more Lit-savvy to agree before committing.
>>
>>I'm not certain if this affects your bots or not, but when I test
>>locally, I usually wind up with:
>>
>>60>  lit.py: LitConfig.py:94: note: Unable to find 'bash.exe'.
>>60>  lit.py: lit.cfg:195: note: using clang:
>>'E:/llvm/2013/Debug/bin/clang.EXE'
>>60>  lit.py: lit.cfg:333: note: Did not find clang-interpreter in
>>E:/llvm/2013/Debug/bin;E:/llvm/2013/Debug/bin
>>60>  lit.py: LitConfig.py:94: note: Unable to find 'bash.exe'.
>>60>  lit.py: lit.cfg:271: note: Did not find llvm-go in
>>E:/llvm/2013/Debug/bin
>>
>>Do you see the other notes as well?
>>
>>~Aaron
>>
>>_______________________________________________
>>llvm-commits mailing list
>>llvm-commits at cs.uiuc.edu
>>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>