[PATCH] [x86] Provide execution domains for scalar floating point operations.

Quentin Colombet qcolombet at apple.com
Wed Feb 4 13:09:49 PST 2015


Hi Chandler,

LGTM.

> Note that this use a 'let ExeDomain = ... in' mechanism rather than threading it through all of the multiclasses the way I did in r228135. I'm interested in which approach seems more appropriate, and I'm happy to make them both converge on that.


I am not sure there is a right answer here. 'let ExeDomain = ... in' is convenient when we have a bunch of instructions we want to put on one domain. However, in the instruction per instruction case it is more verbose. That being said, I tend to prefer the 'let' writing as it makes the information stands out.

Thanks,
Q.


http://reviews.llvm.org/D7402

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list