> I could have both sides of the if use the same code - but it would have to be the one for the ConstantExpr side. Is that better? Yes, I think that would be better. Do that, and LGTM. http://reviews.llvm.org/D7411 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/