PATCH: Don't warn if bash is missing
NAKAMURA Takumi
geek4civic at gmail.com
Tue Feb 3 15:07:31 PST 2015
I would agree pruning bash.exe things if we abandon msys-bash stuff.
I haven't tested mingw on msys for over an year.
Michael, I guess you may demote a warning to a note. Weren't you satisfied?
2015-01-30 3:55 GMT+09:00 Reid Kleckner <rnk at google.com>:
> I don't have Michael's original patch yet (maybe llvm-commits is slow?), but
> I agree with the concept. We don't need a warning for this.
>
> On Thu, Jan 29, 2015 at 10:45 AM, Aaron Ballman <aaron at aaronballman.com>
> wrote:
>>
>> On Thu, Jan 29, 2015 at 1:19 PM, Edwards, Michael
>> <Michael_Edwards at playstation.sony.com> wrote:
>> > Hi,
>> >
>> >
>> > It looks like bash will always be available on the supported platforms
>> > except Windows. In Windows we can run the tests without bash. I'm
>> > hoping
>> > we can remove this warning as it is causing my Buildbots to remain
>> > yellow
>> > all the time. I'm not sure if it is needed anywhere else?
>>
>> I would love to see that warning go away, and this patch LGTM, but you
>> should wait for someone more Lit-savvy to agree before committing.
>>
>> I'm not certain if this affects your bots or not, but when I test
>> locally, I usually wind up with:
>>
>> 60> lit.py: LitConfig.py:94: note: Unable to find 'bash.exe'.
>> 60> lit.py: lit.cfg:195: note: using clang:
>> 'E:/llvm/2013/Debug/bin/clang.EXE'
>> 60> lit.py: lit.cfg:333: note: Did not find clang-interpreter in
>> E:/llvm/2013/Debug/bin;E:/llvm/2013/Debug/bin
>> 60> lit.py: LitConfig.py:94: note: Unable to find 'bash.exe'.
>> 60> lit.py: lit.cfg:271: note: Did not find llvm-go in
>> E:/llvm/2013/Debug/bin
>>
>> Do you see the other notes as well?
>>
>> ~Aaron
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
More information about the llvm-commits
mailing list