[llvm] r228049 - [CMake] add_llvm_library: don't use .imp suffix for import libraries on Windows (PR22334)
Hans Wennborg
hans at hanshq.net
Tue Feb 3 14:08:21 PST 2015
Author: hans
Date: Tue Feb 3 16:08:20 2015
New Revision: 228049
URL: http://llvm.org/viewvc/llvm-project?rev=228049&view=rev
Log:
[CMake] add_llvm_library: don't use .imp suffix for import libraries on Windows (PR22334)
This was added in r188351 to fix a naming conflict between the
profile_rt-static and profile_rt-shared who both ended up in
lib/profile_rt.lib.
The change also affected other libraries (like libclang), and
users are reporting that they find it surprising that there's
no longer a libclang.lib. Since the profile_rt naming conflict
doesn't seem to exist any more, I think we can remove this.
Differential Revision: http://reviews.llvm.org/D7391
Modified:
llvm/trunk/cmake/modules/AddLLVM.cmake
Modified: llvm/trunk/cmake/modules/AddLLVM.cmake
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/AddLLVM.cmake?rev=228049&r1=228048&r2=228049&view=diff
==============================================================================
--- llvm/trunk/cmake/modules/AddLLVM.cmake (original)
+++ llvm/trunk/cmake/modules/AddLLVM.cmake Tue Feb 3 16:08:20 2015
@@ -334,11 +334,6 @@ function(llvm_add_library name)
PREFIX ""
)
endif()
- if (MSVC)
- set_target_properties(${name}
- PROPERTIES
- IMPORT_SUFFIX ".imp")
- endif ()
endif()
if(ARG_MODULE OR ARG_SHARED)
More information about the llvm-commits
mailing list