[PATCH] [CMake] add_llvm_library: don't use .imp suffix for import libraries on Windows (PR22334)
Hans Wennborg
hans at chromium.org
Tue Feb 3 13:55:58 PST 2015
Hi rnk, chapuni,
This was added in r188351 to fix a naming conflict between the profile_rt-static and profile_rt-shared who both ended up in lib/profile_rt.lib.
The change also affected other libraries (like libclang), and users are reporting that they find it surprising that there's no longer a libclang.lib. Since the profile_rt naming conflict doesn't seem to exist any more, I think we can remove this.
http://reviews.llvm.org/D7391
Files:
cmake/modules/AddLLVM.cmake
Index: cmake/modules/AddLLVM.cmake
===================================================================
--- cmake/modules/AddLLVM.cmake
+++ cmake/modules/AddLLVM.cmake
@@ -334,11 +334,6 @@
PREFIX ""
)
endif()
- if (MSVC)
- set_target_properties(${name}
- PROPERTIES
- IMPORT_SUFFIX ".imp")
- endif ()
endif()
if(ARG_MODULE OR ARG_SHARED)
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7391.19264.patch
Type: text/x-patch
Size: 393 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150203/f8e14464/attachment.bin>
More information about the llvm-commits
mailing list