[PATCH] Canonicalize splats as build_vectors (PR22283)
Michael Kuperstein
michael.m.kuperstein at intel.com
Tue Feb 3 13:44:14 PST 2015
>From the x86 point of view, LGTM with a small nit.
Can't help you with ARM code quality, though.
================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:1563
@@ +1562,3 @@
+
+ SDValue NewBV =getNode(ISD::BUILD_VECTOR, dl, BV->getValueType(0), Ops);
+
----------------
There's a missing space after the =.
http://reviews.llvm.org/D7389
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list