[llvm] r223268 - [Hexagon] Converting member InstrDesc to static variable.

[Rafael Espíndola]

I reported http://llvm.org/bugs/show_bug.cgi?id=22449 to track this.

I wanted to cc you, but looks like you are not on bugzilla.

On 23 January 2015 at 11:07, Colin LeMahieu <colinl at codeaurora.org> wrote:
> Sorry this has been sitting around a while.  I have it planned for the
> static variable to be removed.
>
>
>
> The rough sketch so far is to change the passes that query for these
> instruction flags to create an MCII themselves and convert the member
> functions of HexagonMCInst in to static utility function calls accepting an
> MCII.
>
>
>
> This is part of the larger effort to remove the HexagonMCInst subclass
> entirely since it’s really out of place and has issues with disassembling.
>
>
>
> From: Rafael Espíndola [mailto:rafael.espindola at gmail.com]
> Sent: Friday, January 23, 2015 9:38 AM
> To: Colin LeMahieu
> Cc: llvm-commits; Eric Christopher
> Subject: Re: [llvm] r223268 - [Hexagon] Converting member InstrDesc to
> static variable.
>
>
>
>
>
>
>
> On 8 December 2014 at 13:56, Rafael Espíndola <rafael.espindola at gmail.com>
> wrote:
>
> On 8 December 2014 at 11:20, Colin LeMahieu <colinl at codeaurora.org> wrote:
>> That's a good question it's entirely possible this code has never been
>> used in the fashion you've described.
>>
>> From what I've seen of the usage of this variable it only accesses TSFlags
>> which I assumed would be the same across contexts.  This variable was
>> created in lieu of calling createHexagonMCInstrInfo every time we need to
>> access TSFlags at the MC level.
>
> Not sure. What do other backends do?
>
>
>
> cc Eric. He might know.
>
>
>
> Context: the issue is the static std::unique_ptr <MCInstrInfo const> MCII;
> in HexagonMCInst.h, which is problematic if there are two independent users
> of llvm.
>
>
>
> Cheers,
>
> Rafael
>
>
>
>