[PATCH] Modularizing LICM

[Bruno Cardoso Lopes]

Hi,

The approach looks good. Aside from Hal's suggestions, only a few comments.


REPOSITORY
  rL LLVM

================
Comment at: include/llvm/Transforms/Utils/LoopUtils.h:92
@@ +91,3 @@
+/// PromoteAliasSet - Try to promote memory values to scalars by sinking
+/// stores out of the loop and moving loads to before the loop.  We do this by
+/// looping over the stores in the loop, looking for stores to Must pointers
----------------
Please don't repeat the function/method in the comments. Use "\brief" instead. Also fix this issue in other places of the patch too.

================
Comment at: lib/Transforms/Scalar/LICM.cpp:995
@@ +994,2 @@
+}
+
----------------
Any specific reason why this was moved to the end of the file?

http://reviews.llvm.org/D7291

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/