[PATCH] [lld] Make ELFLinkingContext own LinkerScript buffers

Rui Ueyama ruiu at google.com
Mon Feb 2 11:53:37 PST 2015


LGTM


================
Comment at: include/lld/ReaderWriter/ELFLinkingContext.h:13
@@ -12,2 +12,3 @@
 
+#include "LinkerScript.h"
 #include "lld/Core/LinkingContext.h"
----------------
Add "lld/ReaderWriter/" for consistency with other headers.

================
Comment at: include/lld/ReaderWriter/LinkerScript.h:755
@@ +754,3 @@
+  LinkerScript *get() {
+      return &_script;
+  }
----------------
Indentation. (You could actually write this method in one line instead of three lines.)

http://reviews.llvm.org/D7323

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list