[patch] Simplify arange output

David Blaikie dblaikie at gmail.com
Mon Feb 2 09:32:39 PST 2015


On Mon, Feb 2, 2015 at 7:48 AM, Rafael EspĂ­ndola <rafael.espindola at gmail.com
> wrote:

> On 1 February 2015 at 19:58, David Blaikie <dblaikie at gmail.com> wrote:
> > Might be easier to review in Phab.
> >
> > I get some/most of it - but not sure about some other bits. Like why did
> the
> > "if (!Section) {" section move from before to after the sort ("// Sort
> the
> > symbols by offset within the section.")?
>
> I created http://reviews.llvm.org/D7347.
>

Thanks - that helps a lot. Replied with a few comments on the review.


>
> The code is simpler with the move since that is a simple case and
> becomes just if(..) {...; continue;}
>

Ah, I can see it now - thanks!


>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150202/f42efbde/attachment.html>


More information about the llvm-commits mailing list