[PATCH] [ELF] Support for parsing OUTPUT command in LinkerScript

Rafael Auler rafaelauler at gmail.com
Sun Feb 1 19:46:27 PST 2015


Well, I think no file is left open. After MemoryBuffer::getFileOrSTDIN(), the memory buffer is simply filled in with the file contents, and the file is closed right before this call finishes and the lexer starts its work. So, my original point was that, since we already copied the entire file to a separate memory buffer, we would be duplicating work by creating new strings and duplicating the contents of this memory buffer in several small string buffers.


http://reviews.llvm.org/D7326

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list