LGTM. Next time, could you please upload your diffs with "git diff -U999999 <other-branch>"? This way, we get more context here on Phabricator. Thanks for the patch. http://reviews.llvm.org/D7326 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/