Although I don't see major problems with your patch, I like Rui's proposed approach better. http://reviews.llvm.org/D7323 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/