[PATCH] libc++ tests: wait_until.pass test sporadically fails (bug 21998)
Eric Fiselier
eric at efcs.ca
Fri Jan 30 20:34:59 PST 2015
LGTM after the inline comment in answered. Do you need somebody to commit this for you?
REPOSITORY
rL LLVM
================
Comment at: test/std/thread/futures/futures.shared_future/wait_until.pass.cpp:31
@@ +30,3 @@
+{
+ thread_state.store(state, std::memory_order_relaxed);
+}
----------------
Why use a relaxed and not strict memory ordering? If we use strict ordering (the default) then we can just use the assignment operators to write to `thread_state` and we can remove this function.
http://reviews.llvm.org/D6750
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list