[PATCH] MachO: Move LayoutPass to MachO directory.

Rui Ueyama ruiu at google.com
Fri Jan 30 18:54:15 PST 2015


Hi kledzik,

The real user of the LayoutPass is now only Mach-O, so move that
pass out of the common directory to Mach-O directory.

"Core" architecture were using the LayoutPass. I modified that
to use a simple OrderPass. I think no one actually have authority
what feature should be in Core and what's not, but I believe the
LayoutPass is not very suitable for Core. Before more code starts
depending on the complex pass, it's better to remove that from
Core.

I could have simplified that pass because Mach-O is the only user
of the LayoutPass. For example, the second parameter of the
LayoutPass constructor can be converted from optional to mandatory.
I didn't do that in this patch to keep it simple. I'll do in a
followup patch.

http://reviews.llvm.org/D7311

Files:
  include/lld/Passes/LayoutPass.h
  include/lld/ReaderWriter/MachOLinkingContext.h
  lib/Passes/CMakeLists.txt
  lib/Passes/LayoutPass.cpp
  lib/ReaderWriter/CoreLinkingContext.cpp
  lib/ReaderWriter/MachO/CMakeLists.txt
  lib/ReaderWriter/MachO/LayoutPass.cpp
  lib/ReaderWriter/MachO/LayoutPass.h
  lib/ReaderWriter/MachO/MachOLinkingContext.cpp
  lib/ReaderWriter/MachO/MachOPasses.h
  test/core/layout-transitivity.objtxt
  test/core/layoutafter-test.objtxt
  test/core/section-position.objtxt

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7311.19076.patch
Type: text/x-patch
Size: 55760 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150131/5afed108/attachment.bin>


More information about the llvm-commits mailing list