[PATCH] [PM] Change the core design of the TTI analysis to use a polymorphic type erased interface and a single analysis pass rather than an extremely complex analysis group.
hfinkel at anl.gov
hfinkel at anl.gov
Fri Jan 30 18:42:07 PST 2015
We had a long discussion about this design on IRC, and I'm relatively happy with this now. Please go ahead.
================
Comment at: include/llvm/Analysis/TargetTransformInfo.h:58
@@ -65,1 +57,3 @@
+ /// \brief Construct a TTI object around a type which implements the API in
+ /// the \c Concept below.
///
----------------
I understand the comment, but I think it can be made less potentially-confusing. How about:
Construct a TTI object using a type implementing the Concept API below.
================
Comment at: include/llvm/Analysis/TargetTransformInfoImpl.h:54
@@ +53,3 @@
+
+ unsigned getOperationCost(unsigned Opcode, Type *Ty, Type *OpTy) {
+ switch (Opcode) {
----------------
Nevermind. ;)
http://reviews.llvm.org/D7293
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list