[PATCH] [TSan][MIPS64] Fix few more test cases for MIPS64
Alexey Samsonov
vonosmas at gmail.com
Fri Jan 30 11:58:45 PST 2015
REPOSITORY
rL LLVM
================
Comment at: lib/tsan/rtl/tsan_interceptors.cc:1898
@@ -1897,3 +1897,3 @@
VarSizeStackTrace stack;
// Add 1 to pc because return address is expected,
// OutputReport() will undo this.
----------------
Fix a comment here
================
Comment at: test/tsan/global_race.cc:19
@@ +18,3 @@
+#elif defined(__mips64)
+ fprintf(stderr, "addr=0x%010lx\n", (unsigned long) GlobalData);
+#endif
----------------
Instead of spreading #ifdef around the code, you can introduce the function that prints address with required number of leading zeros, and add it to test/tsan/test.h
http://reviews.llvm.org/D7290
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list