[llvm] r227479 - Disable compilation of llvm-pdbdump for versions of MSVC < 2013.

Kaylor, Andrew andrew.kaylor at intel.com
Thu Jan 29 17:16:18 PST 2015


This still didn't fix it for me.

I don't know if this is  quirk of the version of cmake I'm using, but I needed to do this to get it to not try to build llvm-pdbdump:

Index: tools/CMakeLists.txt
===================================================================
--- tools/CMakeLists.txt        (revision 227508)
+++ tools/CMakeLists.txt        (working copy)
@@ -66,6 +66,8 @@
   # MSVC 2013 and higher.  Since this is strictly a utility, and since we hope
   # to drop support for MSVC 2012 soon, don't build this for MSVC < 2013.
   add_llvm_tool_subdirectory(llvm-pdbdump)
+else()
+  ignore_llvm_tool_subdirectory(llvm-pdbdump)
 endif()

 if(NOT CYGWIN AND LLVM_ENABLE_PIC)



-----Original Message-----
From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Zachary Turner
Sent: Thursday, January 29, 2015 10:44 AM
To: llvm-commits at cs.uiuc.edu
Subject: [llvm] r227479 - Disable compilation of llvm-pdbdump for versions of MSVC < 2013.

Author: zturner
Date: Thu Jan 29 12:44:14 2015
New Revision: 227479

URL: http://llvm.org/viewvc/llvm-project?rev=227479&view=rev
Log:
Disable compilation of llvm-pdbdump for versions of MSVC < 2013.

Certain aspects of llvm-pdbdump require language support only present in MSVC 2013 and higher.  Since this is strictly a utility, and since we hope to drop support for MSVC 2012 soon, don't build this unless MSVC 2013 or higher.

Modified:
    llvm/trunk/tools/CMakeLists.txt

Modified: llvm/trunk/tools/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/CMakeLists.txt?rev=227479&r1=227478&r2=227479&view=diff
==============================================================================
--- llvm/trunk/tools/CMakeLists.txt (original)
+++ llvm/trunk/tools/CMakeLists.txt Thu Jan 29 12:44:14 2015
@@ -61,7 +61,10 @@ add_llvm_tool_subdirectory(yaml2obj)
 
 add_llvm_tool_subdirectory(llvm-go)
 
-if(MSVC)
+if(MSVC AND NOT(MSVC_VERSION LESS 1800))
+  # Certain aspects of llvm-pdbdump require language support only 
+present in
+  # MSVC 2013 and higher.  Since this is strictly a utility, and since 
+we hope
+  # to drop support for MSVC 2012 soon, don't build this for MSVC < 2013.
   add_llvm_tool_subdirectory(llvm-pdbdump)
 endif()
 


_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list