[llvm] r227437 - Cleanup a few tests on sse4a machines and FileCheckize along the way.

Eric Christopher echristo at gmail.com
Thu Jan 29 12:16:57 PST 2015 

I mentioned this in irc, but I'm not entirely certain the changes to remove
sse4a from these testcases is correct. Could you please investigate what
made you need to do this?

The rest of it looks like a great cleanup, thanks!

-eric

On Thu Jan 29 2015 at 5:36:33 AM Alex Rosenberg <alexr at leftfield.org> wrote:

> Author: alexr
> Date: Thu Jan 29 07:31:32 2015
> New Revision: 227437
>
> URL: http://llvm.org/viewvc/llvm-project?rev=227437&view=rev
> Log:
> Cleanup a few tests on sse4a machines and FileCheckize along the way.
>
> Modified:
>     llvm/trunk/test/CodeGen/X86/2006-05-22-FPSetEQ.ll
>     llvm/trunk/test/CodeGen/X86/2009-01-25-NoSSE.ll
>     llvm/trunk/test/CodeGen/X86/2009-06-18-movlp-shuffle-register.ll
>     llvm/trunk/test/CodeGen/X86/barrier.ll
>     llvm/trunk/test/CodeGen/X86/nosse-varargs.ll
>     llvm/trunk/test/CodeGen/X86/sse4a.ll
>
> Modified: llvm/trunk/test/CodeGen/X86/2006-05-22-FPSetEQ.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/
> CodeGen/X86/2006-05-22-FPSetEQ.ll?rev=227437&r1=227436&r2=227437&view=diff
> ============================================================
> ==================
> --- llvm/trunk/test/CodeGen/X86/2006-05-22-FPSetEQ.ll (original)
> +++ llvm/trunk/test/CodeGen/X86/2006-05-22-FPSetEQ.ll Thu Jan 29 07:31:32
> 2015
> @@ -1,7 +1,10 @@
> -; RUN: llc < %s -march=x86 -mattr=-sse | grep setnp
> -; RUN: llc < %s -march=x86 -mattr=-sse -enable-unsafe-fp-math
> -enable-no-nans-fp-math | \
> -; RUN:   not grep setnp
> +; RUN: llc < %s -march=x86 -mattr=-sse | FileCheck %s
> -check-prefix=WITHNANS
> +; RUN: llc < %s -march=x86 -mattr=-sse -enable-unsafe-fp-math
> -enable-no-nans-fp-math | FileCheck %s -check-prefix=NONANS
>
> +; WITHNANS-LABEL: test:
> +; WITHNANS: setnp
> +; NONANS-LABEL: test:
> +; NONANS-NOT: setnp
>  define i32 @test(float %f) {
>         %tmp = fcmp oeq float %f, 0.000000e+00          ; <i1> [#uses=1]
>         %tmp.upgrd.1 = zext i1 %tmp to i32              ; <i32> [#uses=1]
>
> Modified: llvm/trunk/test/CodeGen/X86/2009-01-25-NoSSE.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/
> CodeGen/X86/2009-01-25-NoSSE.ll?rev=227437&r1=227436&r2=227437&view=diff
> ============================================================
> ==================
> --- llvm/trunk/test/CodeGen/X86/2009-01-25-NoSSE.ll (original)
> +++ llvm/trunk/test/CodeGen/X86/2009-01-25-NoSSE.ll Thu Jan 29 07:31:32
> 2015
> @@ -1,4 +1,4 @@
> -; RUN: llc < %s -march=x86-64 -mattr=-sse,-sse2 | not grep xmm
> +; RUN: llc < %s -march=x86-64 -mattr=-sse,-sse2,-sse4a | FileCheck %s
>  ; PR3402
>  target datalayout =
>  "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-
> f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128"
> @@ -6,6 +6,8 @@ target triple = "x86_64-unknown-linux-gn
>
>  %struct.ktermios = type { i32, i32, i32, i32, i8, [19 x i8], i32, i32 }
>
> +; CHECK-NOT: xmm
> +; CHECK-NOT: ymm
>  define void @foo() nounwind {
>  entry:
>    %termios = alloca %struct.ktermios, align 8
>
> Modified: llvm/trunk/test/CodeGen/X86/2009-06-18-movlp-shuffle-register.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/
> CodeGen/X86/2009-06-18-movlp-shuffle-register.ll?rev=
> 227437&r1=227436&r2=227437&view=diff
> ============================================================
> ==================
> --- llvm/trunk/test/CodeGen/X86/2009-06-18-movlp-shuffle-register.ll
> (original)
> +++ llvm/trunk/test/CodeGen/X86/2009-06-18-movlp-shuffle-register.ll Thu
> Jan 29 07:31:32 2015
> @@ -1,4 +1,4 @@
> -; RUN: llc < %s -march=x86 -mattr=+sse,-sse2 | FileCheck %s
> +; RUN: llc < %s -march=x86 -mattr=+sse,-sse2,-sse4a | FileCheck %s
>  ; PR2484
>
>  define <4 x float> @f4523(<4 x float> %a,<4 x float> %b) nounwind {
>
> Modified: llvm/trunk/test/CodeGen/X86/barrier.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/
> CodeGen/X86/barrier.ll?rev=227437&r1=227436&r2=227437&view=diff
> ============================================================
> ==================
> --- llvm/trunk/test/CodeGen/X86/barrier.ll (original)
> +++ llvm/trunk/test/CodeGen/X86/barrier.ll Thu Jan 29 07:31:32 2015
> @@ -1,6 +1,7 @@
> -; RUN: llc < %s -march=x86 -mattr=-sse2 | grep lock
> +; RUN: llc < %s -march=x86 -mattr=-sse2,-sse4a | FileCheck %s
>
>  define void @test() {
> +; CHECK: lock
>         fence seq_cst
>         ret void
>  }
>
> Modified: llvm/trunk/test/CodeGen/X86/nosse-varargs.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/
> CodeGen/X86/nosse-varargs.ll?rev=227437&r1=227436&r2=227437&view=diff
> ============================================================
> ==================
> --- llvm/trunk/test/CodeGen/X86/nosse-varargs.ll (original)
> +++ llvm/trunk/test/CodeGen/X86/nosse-varargs.ll Thu Jan 29 07:31:32 2015
> @@ -1,11 +1,12 @@
> -; RUN: llvm-as < %s > %t
> -; RUN: llc -march=x86-64 -mattr=-sse < %t | not grep xmm
> -; RUN: llc -march=x86-64 < %t | grep xmm
> +; RUN: llc < %s -march=x86-64 -mattr=-sse | FileCheck %s
> -check-prefix=NOSSE
> +; RUN: llc < %s -march=x86-64 | FileCheck %s -check-prefix=YESSSE
>  ; PR3403
>  target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-
> i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-
> v128:128:128-a0:0:64-s0:64:64-f80:128:128"
>  target triple = "x86_64-unknown-linux-gnu"
>         %struct.__va_list_tag = type { i32, i32, i8*, i8* }
>
> +; NOSSE-NOT: xmm
> +; YESSSE: xmm
>  define i32 @foo(float %a, i8* nocapture %fmt, ...) nounwind {
>  entry:
>         %ap = alloca [1 x %struct.__va_list_tag], align 8               ;
> <[1 x %struct.__va_list_tag]*> [#uses=4]
>
> Modified: llvm/trunk/test/CodeGen/X86/sse4a.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/
> CodeGen/X86/sse4a.ll?rev=227437&r1=227436&r2=227437&view=diff
> ============================================================
> ==================
> --- llvm/trunk/test/CodeGen/X86/sse4a.ll (original)
> +++ llvm/trunk/test/CodeGen/X86/sse4a.ll Thu Jan 29 07:31:32 2015
> @@ -1,4 +1,5 @@
>  ; RUN: llc < %s -mtriple=i686-apple-darwin9 -mattr=sse4a | FileCheck %s
> +; RUN: llc < %s -mtriple=x86_64-unknown-linux -mattr=sse4a | FileCheck %s
>
>  define void @test1(i8* %p, <4 x float> %a) nounwind optsize ssp {
>  ; CHECK-LABEL: test1:
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150129/2de048ed/attachment.html>

More information about the llvm-commits mailing list