[llvm] r227319 - Fix LLVMSetMetadata and LLVMAddNamedMetadataOperand for single value MDNodes
Duncan P. N. Exon Smith
dexonsmith at apple.com
Thu Jan 29 09:29:47 PST 2015
SGTM!
> On 2015-Jan-29, at 09:09, Hans Wennborg <hans at chromium.org> wrote:
>
> Björn asked for this and r227339 to be merged to 3.6. Duncan, does
> this sound OK to you?
>
> On Wed, Jan 28, 2015 at 8:36 AM, Bjorn Steinbrink <bsteinbr at gmail.com> wrote:
>> Author: bsteinbr
>> Date: Wed Jan 28 10:35:59 2015
>> New Revision: 227319
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=227319&view=rev
>> Log:
>> Fix LLVMSetMetadata and LLVMAddNamedMetadataOperand for single value MDNodes
>>
>> Summary:
>> MetadataAsValue uses a canonical format that strips the MDNode if it
>> contains only a single constant value. This triggers an assertion when
>> trying to cast the value to a MDNode.
>>
>> Subscribers: llvm-commits
>>
>> Differential Revision: http://reviews.llvm.org/D7165
More information about the llvm-commits
mailing list