[PATCH] [Support][Windows] Unify dialog box suppression and print stack traces on abort.

Aaron Ballman aaron.ballman at gmail.com
Thu Jan 29 08:54:28 PST 2015


On Wed, Jan 28, 2015 at 4:56 PM, Aaron Ballman <aaron.ballman at gmail.com> wrote:
> I have some concerns about calling that trap function from a signal handler,
> and plan to do a bit more research tomorrow (traveling today).

I've done my research, and that trap function needs some serious love
on Windows, but doesn't block this change. LGTM!

Thanks!

~Aaron

>
> On Jan 28, 2015 2:58 PM, "Reid Kleckner" <rnk at google.com> wrote:
>>
>> lgtm
>>
>>
>> http://reviews.llvm.org/D7230
>>
>> EMAIL PREFERENCES
>>   http://reviews.llvm.org/settings/panel/emailpreferences/
>>
>>
>



More information about the llvm-commits mailing list