[PATCH] Partially fix memcpy / memset / memmove lowering in SelectionDAG construction if address space != 0.

Saleem Abdulrasool compnerd at compnerd.org
Wed Jan 28 18:00:38 PST 2015


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:4256
@@ +4255,3 @@
+  if (AS != 0 && !TLI->isNoopAddrSpaceCast(AS, 0)) {
+    report_fatal_error("FIXME: lowering arbitrarily long memcpy / memset / "
+                       "memmove intrinsics for arbitrary address spaces is not "
----------------
The phrasing here could be a bit better IMO.  How about:

    report_fatal_error(Twine("cannot lower memory intrinsic in address space ") + AS);

http://reviews.llvm.org/D7241

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list