[PATCH] [ASan] Make BlockingMutex really linker initialized.

Alexey Samsonov vonosmas at gmail.com
Wed Jan 28 14:57:11 PST 2015


LGTM. Yes, I think enabling -Wglobal-constructors for ASan (and for all the rest sanitizers) will be great. Thank you!


REPOSITORY
  rL LLVM

================
Comment at: lib/sanitizer_common/sanitizer_linux.cc:501
@@ -504,2 +500,3 @@
 void BlockingMutex::Lock() {
+  CHECK_EQ(owner_, 0);
   atomic_uint32_t *m = reinterpret_cast<atomic_uint32_t *>(&opaque_storage_);
----------------
owner_ isn't used in any other BlockingMutex functions on Linux. Let's just delete this line.

http://reviews.llvm.org/D7171

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list