[PATCH] Add lit-style tests for the Fuzzer library

Alexey Samsonov vonosmas at gmail.com
Wed Jan 28 14:33:03 PST 2015


LGTM, once you address the comments. Please watch the bots after commit.


================
Comment at: lib/Fuzzer/CMakeLists.txt:11
@@ +10,2 @@
+
+add_subdirectory(test)
----------------
Put this under
  if (LLVM_INCLUDE_TESTS)


================
Comment at: lib/Fuzzer/test/fuzzer.test:1
@@ +1,2 @@
+
+RUN: ./LLVMFuzzer-SimpleTest 2>&1 | FileCheck %s --check-prefix=SimpleTest
----------------
delete empty line

================
Comment at: lib/Fuzzer/test/fuzzer.test:12
@@ +11,3 @@
+TimeoutTest: CRASHED; file written to timeout
+
+RUN: not ./LLVMFuzzer-NullDerefTest 2>&1 | FileCheck %s --check-prefix=NullDerefTest
----------------
What about ExactTest?

================
Comment at: lib/Fuzzer/test/fuzzer.test:14
@@ +13,2 @@
+RUN: not ./LLVMFuzzer-NullDerefTest 2>&1 | FileCheck %s --check-prefix=NullDerefTest
+NullDerefTest: CRASHED; file written to crash-
----------------
Do you need "-" at the end of this line?

================
Comment at: lib/Fuzzer/test/lit.cfg:1
@@ +1,2 @@
+# import lit.util
+import lit.formats
----------------
Delete this line.

================
Comment at: lib/Fuzzer/test/lit.cfg:8
@@ +7,2 @@
+config.test_source_root = os.path.dirname(__file__)
+
----------------
empty line?

http://reviews.llvm.org/D7217

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list