[llvm] r227261 - SymbolRewriter: allow rewriting with comdats

[Hans Wennborg]

On Tue, Jan 27, 2015 at 10:03 PM, Saleem Abdulrasool
<compnerd at compnerd.org> wrote:
> On Tue, Jan 27, 2015 at 2:57 PM, Saleem Abdulrasool <compnerd at compnerd.org>
> wrote:
>>
>> Author: compnerd
>> Date: Tue Jan 27 16:57:39 2015
>> New Revision: 227261
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=227261&view=rev
>> Log:
>> SymbolRewriter: allow rewriting with comdats
>>
>> COMDATs must be identically named to the symbol.  When support for COMDATs
>> was
>> introduced, the symbol rewriter was not updated, resulting in rewriting
>> failing
>> for symbols which were placed into COMDATs.  This corrects the behaviour
>> and
>> adds test cases for this.
>
>
> Hi Hans,
>
> I think we should merge this and the prior change (227260) for the 3.6
> release as it makes this unusable in many cases after the support for
> comdats was added near the end of the branch point.

Merged in r227323 and r227324.

Thanks,
Hans