[PATCH] Make asan_symbolize.py not crash on Windows.

Alexander Potapenko glider at google.com
Wed Jan 28 08:56:02 PST 2015


LGTM


================
Comment at: lib/asan/scripts/asan_symbolize.py:438
@@ -439,5 +437,3 @@
 if __name__ == '__main__':
-  parser = argparse.ArgumentParser(formatter_class=argparse.RawDescriptionHelpFormatter,
-  description='ASan symbolization script',
-  epilog='''Example of use:
-  asan_symbolize.py -c "$HOME/opt/cross/bin/arm-linux-gnueabi-" -s "$HOME/SymbolFiles" < asan.log''')
+  parser = argparse.ArgumentParser(
+      formatter_class=argparse.RawDescriptionHelpFormatter,
----------------
I'd commit the formatting part separately.

================
Comment at: lib/asan/scripts/asan_symbolize.py:474
@@ +473,3 @@
+    for line in logfile:
+      print line,
+    sys.exit(0)
----------------
Nit: spare comma?

http://reviews.llvm.org/D7227

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list