[PATCH] Remove support for pnaclcall attribute

Jan Voung jvoung at chromium.org
Wed Jan 28 08:54:12 PST 2015


Otherwise LGTM too.


================
Comment at: lib/CodeGen/TargetInfo.cpp:3103
@@ -3102,4 +3102,3 @@
  private:
-  PNaClABIInfo PInfo;  // Used for generating calls with pnaclcall callingconv.
   X86_64ABIInfo NInfo; // Used for everything else.
 };
----------------
The ' // Used for everything else' comments here and in the ARM version can be removed too.

Actually, can just the plain X86_64ABIInfo be used where NaClX86_64ABIInfo was, and the latter removed too? Same for ARM.

http://reviews.llvm.org/D7206

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list