[PATCH] [lld][ARM] Add relocations to perform function calls
Will Newton
will.newton at linaro.org
Wed Jan 28 02:33:16 PST 2015
================
Comment at: lib/ReaderWriter/ELF/ARM/ARMRelocationHandler.cpp:161
@@ +160,3 @@
+ DECLARE_T(addressesThumb);
+ const bool exchanges = !addressesThumb;
+
----------------
denis-protivensky wrote:
> wnewton wrote:
> >
> > "addressesThumb" is IMO a more descriptive name than "exchanges" so this variable does not help me to read the code.
> I also doubted about this name, but I'd like to introduce some variable to point that addressing Thumb (or ARM) code for some instructions means 'exchange instruction set'. Any ideas about better name?
switchMode?
http://reviews.llvm.org/D7223
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list