[PATCH] Fix LLVMSetMetadata for MDNodes that contain a single value
Björn Steinbrink
bsteinbr at gmail.com
Tue Jan 27 15:00:09 PST 2015
Thanks for the feedback!
Added a testcase and replaced the ternary operators with if statements.
I did not use an early return for the !Val case though, because that would,
AFAICT, stop the user from removing existing metadata.
http://reviews.llvm.org/D7165
Files:
lib/IR/Core.cpp
test/Bindings/llvm-c/metadata.ll
tools/llvm-c-test/CMakeLists.txt
tools/llvm-c-test/llvm-c-test.h
tools/llvm-c-test/main.c
tools/llvm-c-test/metadata.c
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7165.18856.patch
Type: text/x-patch
Size: 4155 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150127/8bf49c02/attachment.bin>
More information about the llvm-commits
mailing list