[PATCH] New "strict_string_checks" run-time flag

Kostya Serebryany kcc at google.com
Tue Jan 27 12:22:53 PST 2015


This size is more manageable, thanks for splitting.

Id like at least one more reviewer to jump in.


================
Comment at: test/asan/TestCases/atol_strict.c:3
@@ +2,3 @@
+// RUN: %clang_asan %s -o %t && not %run %t 2>&1 | FileCheck %s
+// RUN: ASAN_OPTIONS=strict_string_checks=false %run %t 2>&1
+// RUN: ASAN_OPTIONS=strict_string_checks=true not %run %t 2>&1 | FileCheck %s
----------------
here and below, add a 3-rd RUN line to run w/o ASAN_OPTIONS (i.e. to test what's default)

================
Comment at: test/asan/Unit/lit.site.cfg.in:33
@@ +32,2 @@
+# Disable strict str checks in unit tests
+config.environment['ASAN_OPTIONS'] = 'strict_string_checks=false'
----------------
Hm. Why?

http://reviews.llvm.org/D7123

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list