[PATCH] Avoid combining adjacent stores at -O0 to improve debug experience

Jim Grosbach grosbach at apple.com
Mon Jan 26 15:09:42 PST 2015


There should be exactly zero DAG combines that have to run, ever. They are by definition not required for correctness. Anything else is a bug, and a bad one.

> On Jan 26, 2015, at 3:02 PM, Paul Robinson <Paul_Robinson at playstation.sony.com> wrote:
> 
> If I disable DAGCombine at -O0, I get 19 test failures including two crashes.
> Abstractly it seems reasonable to do that, or at least identify and separate out the combines that have to run even at -O0; but we're not there now, and I'm probably not the right person to figure that stuff out.
> How about I commit the patch as is, and file a bug for disabling DAGCombine at -O0?
> 
> 
> http://reviews.llvm.org/D7181
> 
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits





More information about the llvm-commits mailing list