[llvm] r227046 - Instantiate Registry<GCStrategy> in LLVMCore, to let it available on Win32 DLL.

[Philip Reames]

I ended up reverting this along with the original ownership change. What 
was the symptom that you were fixing here?  I want to make sure I don't 
reintroduce the failure with future work.

Philip

On 01/25/2015 07:05 AM, NAKAMURA Takumi wrote:
> Author: chapuni
> Date: Sun Jan 25 09:05:36 2015
> New Revision: 227046
>
> URL: http://llvm.org/viewvc/llvm-project?rev=227046&view=rev
> Log:
> Instantiate Registry<GCStrategy> in LLVMCore, to let it available on Win32 DLL.
>
> Modified:
>      llvm/trunk/include/llvm/IR/GCStrategy.h
>      llvm/trunk/lib/IR/GCStrategy.cpp
>
> Modified: llvm/trunk/include/llvm/IR/GCStrategy.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/GCStrategy.h?rev=227046&r1=227045&r2=227046&view=diff
> ==============================================================================
> --- llvm/trunk/include/llvm/IR/GCStrategy.h (original)
> +++ llvm/trunk/include/llvm/IR/GCStrategy.h Sun Jan 25 09:05:36 2015
> @@ -188,6 +188,9 @@ public:
>   /// register your GCMetadataPrinter subclass with the
>   /// GCMetadataPrinterRegistery as well.
>   typedef Registry<GCStrategy> GCRegistry;
> +
> +/// GCStrategy is instantiated in GCStrategy.cpp.
> +extern template class Registry<GCStrategy>;
>   }
>   
>   #endif
>
> Modified: llvm/trunk/lib/IR/GCStrategy.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/GCStrategy.cpp?rev=227046&r1=227045&r2=227046&view=diff
> ==============================================================================
> --- llvm/trunk/lib/IR/GCStrategy.cpp (original)
> +++ llvm/trunk/lib/IR/GCStrategy.cpp Sun Jan 25 09:05:36 2015
> @@ -14,6 +14,8 @@
>   
>   #include "llvm/IR/GCStrategy.h"
>   
> +template class llvm::Registry<llvm::GCStrategy>;
> +
>   using namespace llvm;
>   
>   GCStrategy::GCStrategy()
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits