[llvm] r227118 - Add a FIXME about preferred alignment to DataLayout.
Eric Christopher
echristo at gmail.com
Mon Jan 26 11:19:04 PST 2015
Author: echristo
Date: Mon Jan 26 13:19:04 2015
New Revision: 227118
URL: http://llvm.org/viewvc/llvm-project?rev=227118&view=rev
Log:
Add a FIXME about preferred alignment to DataLayout.
Essentially DataLayout is global and affects the layout of ABI
level objects. Preferred alignment could change on a per function
basis as we change CPU features.
Modified:
llvm/trunk/include/llvm/IR/DataLayout.h
Modified: llvm/trunk/include/llvm/IR/DataLayout.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/DataLayout.h?rev=227118&r1=227117&r2=227118&view=diff
==============================================================================
--- llvm/trunk/include/llvm/IR/DataLayout.h (original)
+++ llvm/trunk/include/llvm/IR/DataLayout.h Mon Jan 26 13:19:04 2015
@@ -53,6 +53,11 @@ enum AlignTypeEnum {
AGGREGATE_ALIGN = 'a'
};
+// FIXME: Currently the DataLayout string carries a "preferred alignment"
+// for types. As the DataLayout is module/global, this should likely be
+// sunk down to an FTTI element that is queried rather than a global
+// preference.
+
/// \brief Layout alignment element.
///
/// Stores the alignment data associated with a given alignment type (integer,
More information about the llvm-commits
mailing list