[PATCH] fix test-suite/SingleSource/UnitTests/ObjC for iOS SDK

Matthias Braun mbraun at apple.com
Mon Jan 26 10:25:35 PST 2015


Thanks for the review. I updated the messages-2 patch as suggested.

- Matthias


> On Jan 23, 2015, at 4:16 PM, Daniel Dunbar <daniel at zuster.org> wrote:
> 
> The patch to messages-2.m should probably just substitute an inline definition of a size class, IIRC (and its been a long time) the test is trying to explicitly check a particular structure layout, so it would be better to just hardcode the definition as:
> --
> typedef struct {
>   float width, height;
> } MySize;
> --
> since this test was originally intended for testing the 32-bit structure layout, I think.
> 
>  - Daniel
> 
> 
> On Fri, Jan 23, 2015 at 2:55 PM, Matthias Braun <mbraun at apple.com <mailto:mbraun at apple.com>> wrote:
> The attached patches fix two problems when running test-suite/SingleSource/UnitTests/ObjC with the iOS SDK.
> 
> - Matthias
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150126/849671dd/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Avoid-using-NSSize-which-is-not-available-on-iOS.patch
Type: application/octet-stream
Size: 4812 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150126/849671dd/attachment.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150126/849671dd/attachment-0001.html>


More information about the llvm-commits mailing list