[PATCH] Jump thread llvm.expect

Philip Reames listmail at philipreames.com
Mon Jan 26 10:19:28 PST 2015


Looks straight forward.  Provided your confident of the answer to my inline question, LGTM.


================
Comment at: lib/Transforms/Scalar/JumpThreading.cpp:520
@@ -512,3 +519,3 @@
         Value *LHS = PN->getIncomingValue(i);
         Value *RHS = Cmp->getOperand(1)->DoPHITranslation(BB, PredBB);
 
----------------
Can the PHITranslation now fail with your change?

================
Comment at: test/Transforms/JumpThreading/expect.ll:10
@@ +9,3 @@
+
+define i64 @test(i1 %cond) {
+	br i1 %cond, label %T1, label %F1
----------------
Please use CHECK-LABEL so this file is easy to extend later.  

Also, comment description at top of file should be clearer.

http://reviews.llvm.org/D7169

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list