[PATCH] [NFC] Make the maximal loop depth an absolut value.

Tobias Grosser tobias at grosser.es
Sat Jan 24 09:57:20 PST 2015


Hi Johannes,

the patch looks generally reasonable, even though it does not explain why the additional information is necessary. As the patch is rather simple, it should be OK to commit it in case you have a use case for it.


================
Comment at: include/polly/ScopInfo.h:763
@@ +762,3 @@
+  inline unsigned getMaxLoopDepthInScop() const {
+    return MaxLoopDepth - MinLoopDepth + (MinLoopDepth ? 1 : 0);
+  }
----------------
Why do we need to add one only in case MinLoopDepth > 0? This may be worth a comment.

http://reviews.llvm.org/D6072

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list