[llvm] r221915 - Object, Mach-O: Refactor and clean code up

[Rafael Espíndola]

On 23 January 2015 at 17:14, Kevin Enderby <enderby at apple.com> wrote:

> Added Lang to the To: line and he maybe better to comment.
>
> While the change looks cleaner I’m not sure what the error handling should
> be for malformed Mach-O files in llvm’s libObject.  If malformed Mach-O
> files cause asserts it is difficult to build tools to print and diagnose
> bad files.  For example in Mac OS otool(1) is used both to display
> information about good Mach-O files and do its best to display what it can
> with warning about  malformed Mach-O files.  For the guy producing Mach-O
> files which some times are broken this is a valuable approach for have
> otool(1) be able so show what it can instead of just stopping.
>

I agree that it should not assert.

The intention was to point out that the original change was (and still is)
untested.

Cheers,
Rafael
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150123/e5efc3d4/attachment.html>