[PATCH] [lld] Break cyclic dependency between lldDriver and lldMachO

Rui Ueyama ruiu at google.com
Fri Jan 23 15:15:53 PST 2015


LGTM. By the way when you upload a patch to Phabricator, please run diff with -u 100000 or something, so that entire file is included in a diff. That would help reviewers review code. Thanks!


REPOSITORY
  rL LLVM

================
Comment at: include/lld/ReaderWriter/MachOLinkingContext.h:256
@@ -255,1 +255,3 @@
 
+  // Reads a file from disk to memory. Returns only a needed chunk
+  // if a fat binary.
----------------
Please move this after private:.

http://reviews.llvm.org/D7155

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list