[PATCH] [LSan] [MIPS] adding support of LSan for mips64/mips64el arch

Sergey Matveev earthdok at google.com
Fri Jan 23 11:58:16 PST 2015


lgtm with nits

Please don't forget to implement clone().


REPOSITORY
  rL LLVM

================
Comment at: lib/sanitizer_common/sanitizer_linux_libcdep.cc:168
@@ +167,3 @@
+// head structure. It lies before the static tls blocks.
+uptr TlsPreTcbSize() {
+  const uptr kTcbHead = 16;
----------------
static

================
Comment at: lib/sanitizer_common/tests/sanitizer_linux_test.cc:260
@@ +259,3 @@
+TEST(SanitizerLinux, ThreadSelfTest) {
+  ASSERT_EQ(pthread_self(), ThreadSelf());
+}
----------------
This needs a comment:

// Effectively, this is a test for ThreadDescriptorSize() which is used to compute ThreadSelf().

http://reviews.llvm.org/D7013

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list