[PATCH] Incorrect loop limit computation in LFTR

Sanjoy Das sanjoy at playingwithpointers.com
Fri Jan 23 02:24:29 PST 2015


The code is perfectly fine; I just misread it, as I said. :)

I've abandoned the revision on phabricator.

Sent from a mobile device, please excuse typos.
On Jan 23, 2015 2:14 AM, "David Majnemer" <david.majnemer at gmail.com> wrote:

> Here was my thinking when I wrote the check you are modifying:
>
> 1. If we are going to compare against the post-incremented induction
> variable, the IndVar had better not have a wrapping flag.
> 2. Otherwise, we should compare against the pre-incremented induction
> variable.
>
> Is there a reason why option number two isn't viable? I assumed that
> `IndVar` and `BackedgeTakenCount` would contain the correct values to
> compare.
>
>
> http://reviews.llvm.org/D7137
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150123/79c6de84/attachment.html>


More information about the llvm-commits mailing list