[llvm] r226867 - Remove dead leak detector parts that fell out of use in r224703.
Benjamin Kramer
benny.kra at googlemail.com
Thu Jan 22 13:43:01 PST 2015
Author: d0k
Date: Thu Jan 22 15:43:01 2015
New Revision: 226867
URL: http://llvm.org/viewvc/llvm-project?rev=226867&view=rev
Log:
Remove dead leak detector parts that fell out of use in r224703.
Removed:
llvm/trunk/lib/IR/LeaksContext.h
Modified:
llvm/trunk/lib/IR/LLVMContextImpl.cpp
llvm/trunk/lib/IR/LLVMContextImpl.h
Modified: llvm/trunk/lib/IR/LLVMContextImpl.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/LLVMContextImpl.cpp?rev=226867&r1=226866&r2=226867&view=diff
==============================================================================
--- llvm/trunk/lib/IR/LLVMContextImpl.cpp (original)
+++ llvm/trunk/lib/IR/LLVMContextImpl.cpp Thu Jan 22 15:43:01 2015
@@ -97,8 +97,7 @@ LLVMContextImpl::~LLVMContextImpl() {
delete I;
#include "llvm/IR/Metadata.def"
- // Free the constants. This is important to do here to ensure that they are
- // freed before the LeakDetector is torn down.
+ // Free the constants.
std::for_each(ExprConstants.map_begin(), ExprConstants.map_end(),
DropFirst());
std::for_each(ArrayConstants.map_begin(), ArrayConstants.map_end(),
Modified: llvm/trunk/lib/IR/LLVMContextImpl.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/LLVMContextImpl.h?rev=226867&r1=226866&r2=226867&view=diff
==============================================================================
--- llvm/trunk/lib/IR/LLVMContextImpl.h (original)
+++ llvm/trunk/lib/IR/LLVMContextImpl.h Thu Jan 22 15:43:01 2015
@@ -17,7 +17,6 @@
#include "AttributeImpl.h"
#include "ConstantsContext.h"
-#include "LeaksContext.h"
#include "llvm/ADT/APFloat.h"
#include "llvm/ADT/APInt.h"
#include "llvm/ADT/ArrayRef.h"
@@ -392,9 +391,6 @@ public:
ConstantInt *TheTrueVal;
ConstantInt *TheFalseVal;
-
- LeakDetectorImpl<Value> LLVMObjects;
- LeakDetectorImpl<Metadata> LLVMMDObjects;
// Basic type instances.
Type VoidTy, LabelTy, HalfTy, FloatTy, DoubleTy, MetadataTy;
Removed: llvm/trunk/lib/IR/LeaksContext.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/LeaksContext.h?rev=226866&view=auto
==============================================================================
--- llvm/trunk/lib/IR/LeaksContext.h (original)
+++ llvm/trunk/lib/IR/LeaksContext.h (removed)
@@ -1,103 +0,0 @@
-//===- LeaksContext.h - LeadDetector Implementation ------------*- C++ -*--===//
-//
-// The LLVM Compiler Infrastructure
-//
-// This file is distributed under the University of Illinois Open Source
-// License. See LICENSE.TXT for details.
-//
-//===----------------------------------------------------------------------===//
-//
-// This file defines various helper methods and classes used by
-// LLVMContextImpl for leaks detectors.
-//
-//===----------------------------------------------------------------------===//
-
-#ifndef LLVM_LIB_IR_LEAKSCONTEXT_H
-#define LLVM_LIB_IR_LEAKSCONTEXT_H
-
-#include "llvm/ADT/SmallPtrSet.h"
-#include "llvm/IR/Metadata.h"
-#include "llvm/IR/Value.h"
-#include "llvm/Support/raw_ostream.h"
-
-namespace llvm {
-
-template <class T>
-struct PrinterTrait {
- static void print(const T* P) { errs() << P; }
-};
-
-template<>
-struct PrinterTrait<Value> {
- static void print(const Value* P) { errs() << *P; }
-};
-
-template <> struct PrinterTrait<Metadata> {
- static void print(const Metadata *P) { P->print(errs()); }
-};
-
-template <typename T>
-struct LeakDetectorImpl {
- explicit LeakDetectorImpl(const char* const name = "") :
- Cache(nullptr), Name(name) { }
-
- void clear() {
- Cache = nullptr;
- Ts.clear();
- }
-
- void setName(const char* n) {
- Name = n;
- }
-
- // Because the most common usage pattern, by far, is to add a
- // garbage object, then remove it immediately, we optimize this
- // case. When an object is added, it is not added to the set
- // immediately, it is added to the CachedValue Value. If it is
- // immediately removed, no set search need be performed.
- void addGarbage(const T* o) {
- assert(Ts.count(o) == 0 && "Object already in set!");
- if (Cache) {
- assert(Cache != o && "Object already in set!");
- Ts.insert(Cache);
- }
- Cache = o;
- }
-
- void removeGarbage(const T* o) {
- if (o == Cache)
- Cache = nullptr; // Cache hit
- else
- Ts.erase(o);
- }
-
- bool hasGarbage(const std::string& Message) {
- addGarbage(nullptr); // Flush the Cache
-
- assert(!Cache && "No value should be cached anymore!");
-
- if (!Ts.empty()) {
- errs() << "Leaked " << Name << " objects found: " << Message << ":\n";
- for (typename SmallPtrSet<const T*, 8>::iterator I = Ts.begin(),
- E = Ts.end(); I != E; ++I) {
- errs() << '\t';
- PrinterTrait<T>::print(*I);
- errs() << '\n';
- }
- errs() << '\n';
-
- return true;
- }
-
- return false;
- }
-
-private:
- SmallPtrSet<const T*, 8> Ts;
- const T* Cache;
- const char* Name;
-};
-
-}
-
-#endif
More information about the llvm-commits
mailing list