[PATCH] Refactoring cl::parser construction and initialization.

Duncan P. N. Exon Smith dexonsmith at apple.com
Thu Jan 22 13:01:02 PST 2015


LGTM.

> On 2015-Jan-22, at 12:49, Chris Bieneman <beanz at apple.com> wrote:
> 
> Hi dexonsmith,
> 
> Some parsers need references back to the option they are members of. This is used for handling the argument string as well as by the various pass name parsers for making pass names into flags.
> 
> Making parsers that need to refer back to the option have a reference to the option eliminates some of the members of various parsers, and enables further code cleanup.
> 
> http://reviews.llvm.org/D7131
> 
> Files:
>  include/llvm/CodeGen/MachinePassRegistry.h
>  include/llvm/IR/LegacyPassNameParser.h
>  include/llvm/Support/CommandLine.h
>  lib/IR/Pass.cpp
> 
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
> <D7131.18635.patch>





More information about the llvm-commits mailing list