[PATCH] [lld] Fix the ELF shared library build targets

Greg Fitzgerald garious at gmail.com
Thu Jan 22 11:43:53 PST 2015


Hi Shankar,

> Could we keep the headers for each of the Target linking contexts inside each target itself.

I'm not sure exactly what you're asking for.  Do you want the header
that describe's the component's public interface to stay close to
home?  Or do you not want some other, presumably smaller, interface to
represent the public interface?

Thanks,
Greg


On Thu, Jan 22, 2015 at 4:11 AM, Shankar Easwaran
<shankar.kalpathi.easwaran at gmail.com> wrote:
> Could we keep the headers for each of the Target linking contexts inside each target itself.
>
>
> REPOSITORY
>   rL LLVM
>
> ================
> Comment at: lib/Driver/GnuLdDriver.cpp:25
> @@ -18,2 +24,3 @@
> +#include "lld/ReaderWriter/ELF/X86_64LinkingContext.h"
>  #include "lld/ReaderWriter/LinkerScript.h"
>  #include "llvm/ADT/ArrayRef.h"
> ----------------
> Can you create a header file that contains all the elf targets. You need to sort all the includes without this though.
>
> http://reviews.llvm.org/D7119
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>



More information about the llvm-commits mailing list