[PATCH] tsan: do not instrument not captured values

Dmitry Vyukov dvyukov at google.com
Wed Jan 21 23:15:21 PST 2015


On Thu, Jan 22, 2015 at 4:18 AM, Kostya Serebryany <kcc at google.com> wrote:
> Cool.
> Do you have any numbers? (E.g. the %% of cases where it fires on SPEC)?

See the change description.

> Two comments inlined
>
>
> ================
> Comment at: lib/Transforms/Instrumentation/ThreadSanitizer.cpp:349
> @@ +348,3 @@
> +  DominatorTree DT;
> +  DT.recalculate(F);
> +
> ----------------
> Don't we want to reuse DT from previous passes, i.e. require it in getAnalysisUsage() ?
>
> ================
> Comment at: test/Instrumentation/ThreadSanitizer/capture.ll:17
> @@ +16,3 @@
> +}
> +; CHECK: define void @captured0
> +; CHECK: __tsan_write
> ----------------
> CHECK-LABEL, here and below
>
> http://reviews.llvm.org/D7069
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>



More information about the llvm-commits mailing list